Separated T in nodeData from Criteria #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ListBasedServiceRegistry along with the MapBased one 1) Added a criteria interface in the ShardSelector to keep it seperate from the T in ServiceNode and trickled the changes upstream to whereever ShardSelector is getting built. 2) Added test cases to the new criteria interface 3) Added Http serivceNodeProvider and serviceFinders, along with the HttpServiceFinderHub 4) Added tests for Http interfaces as well. 5) Added license to the missing files 6) Fixed sonar issues
…for when it has to be latter passed down as an arg to a function. b) .equalsIgnoreCase in selector tests has crept in during the previous sonar lints, corrected the same. c) Addressed sonar lint issues on license block
…rce formatting c) Reverted the version change to have the APIs begin with a version
This was referenced Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of the MR: #41, which is an extension of MR #31. The intention is to break #41 into smaller components to make it easy to track changes in the future.
Key Changes
ShardSelector<T, C extends Criteria<T>> implements ShardSelector<T, C, R extends Registry<T>>orShardSelector<T> implements ShardSelector<T, Criteria<T>, R extends Registry<T>>. Chose the former to keep the Criteria implementation fluid and to be able to have clients define their shardSelector within the bound of any Criteria implementation.Why separate T and Criteria
To facilitate for clients to dynamically bind inline criteria when implementing shard selectors, to decouple the type of such criteria bound with the generic T type that has been saved as a part of
serviceNode.This will help clients further wing out their own implementations of criteria basis their individual parameters and supply a matcher during node group (shard) selection.