Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on missing dependencies #79

Merged
merged 3 commits into from
Oct 12, 2023
+23 −0
Merged

Error on missing dependencies #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f285abe
Raise error if finufft/cufinufft is missing before we getattr
WardBrian Oct 11, 2023
2ee1b15
Add a test
WardBrian Oct 11, 2023
bf66ad6
Fix test
WardBrian Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pytorch_finufft/functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,8 +696,12 @@ def get_nufft_func(
dim: int, nufft_type: int, device_type: str
) -> Callable[..., torch.Tensor]:
if device_type == "cuda":
WardBrian marked this conversation as resolved.
Show resolved Hide resolved
if not CUFINUFFT_AVAIL:
raise RuntimeError("CUDA device requested but cufinufft failed to import")
return getattr(cufinufft, f"nufft{dim}d{nufft_type}") # type: ignore

if not FINUFFT_AVAIL:
raise RuntimeError("CPU device requested but finufft failed to import")
# CPU needs extra work to go to/from torch and numpy
finufft_func = getattr(finufft, f"nufft{dim}d{nufft_type}")

Expand Down
19 changes: 19 additions & 0 deletions tests/test_errors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,3 +158,22 @@ def test_t1_negative_output_dims() -> None:
ValueError, match="Got output_shape that was not positive integer"
):
pytorch_finufft.functional.finufft_type1.apply(points, values, (10, -2))


# dependencies
def test_finufft_not_installed():
if not pytorch_finufft.functional.CUFINUFFT_AVAIL:
if not torch.cuda.is_available():
pytest.skip("CUDA unavailable")
points = torch.rand(10, dtype=torch.float64).to("cuda")
values = torch.randn(10, dtype=torch.complex128).to("cuda")

with pytest.raises(RuntimeError, match="cufinufft failed to import"):
pytorch_finufft.functional.finufft_type1.apply(points, values, 10)

elif not pytorch_finufft.functional.FINUFFT_AVAIL:
points = torch.rand(10, dtype=torch.float64).to("cpu")
values = torch.randn(10, dtype=torch.complex128).to("cpu")

with pytest.raises(RuntimeError, match="finufft failed to import"):
pytorch_finufft.functional.finufft_type1.apply(points, values, 10)
Loading