Error on missing dependencies #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eickenberg
approved these changes
Oct 11, 2023
tests/test_errors.py
Outdated
|
|
||
| # dependencies | ||
| def test_cuda_finufft_not_installed(): | ||
| pytest.importorskip("finufft") |
There was a problem hiding this comment.
Is this == "if we can import finufft, import it, otherwise skip this test"?
There was a problem hiding this comment.
Yes, which I think means it’s actually the flip of what I wanted it to be, which is a mistake (which I think also lead to the confusion in your second comment, and the test to fail on Jenkins)
I’ll fix it up tomorrow if I can, otherwise this will just be untested which I think is fine
tests/test_errors.py
Outdated
| points = torch.rand(10, dtype=torch.float64).to('cpu') | ||
| values = torch.randn(10, dtype=torch.complex128).to('cpu') | ||
|
|
||
| with pytest.raises(RuntimeError, match="cufinufft failed to import"): |
There was a problem hiding this comment.
By which mechanism do we know that this test is running in the non-cufinufft environment? I don't see where we ensure that cufinufft is not installed
WardBrian
force-pushed
the
error-on-missing-dep
branch
from
75f7c6a to
bf66ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass a CPU array and finufft is unavailable, or if you pass a cuda array and cufinufft is unavailable, we should raise an error