Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic client for ambigious Kind #1088

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Commits on Oct 17, 2024

  1. fix: dynamic client for ambigious Kind

    we were getting resource not found errors when fetching resources with
    the dynamic client.
    
    The issue was that the "Kind" alone wasn't specific enough to get the
    correct dynamic client. Example: I had two HelmChart kinds
    
    helmcharts                                         helm.cattle.io/v1                        true         HelmChart
    helmcharts                         hc              source.toolkit.fluxcd.io/v1              true         HelmChart
    
    Changed that to create the dynamic client for <Group, Version, Kind>
    instead.
    adityathebe committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    530bad5 View commit details
    Browse the repository at this point in the history