fix: dynamic client for ambigious Kind #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
force-pushed
the
fix/dynamic-client
branch
from
dbdb6ee
to
67a304b
Compare
we were getting resource not found errors when fetching resources with the dynamic client. The issue was that the "Kind" alone wasn't specific enough to get the correct dynamic client. Example: I had two HelmChart kinds helmcharts helm.cattle.io/v1 true HelmChart helmcharts hc source.toolkit.fluxcd.io/v1 true HelmChart Changed that to create the dynamic client for <Group, Version, Kind> instead.
adityathebe
force-pushed
the
fix/dynamic-client
branch
from
67a304b
to
530bad5
Compare
adityathebe
commented
Oct 17, 2024
Comment on lines
+113
to
+114
| gv, _ := schema.ParseGroupVersion(resource.APIVersion) | ||
| kclient, err = ctx.KubernetesDynamicClient().GetClientByGroupVersionKind(gv.Group, gv.Version, resource.Kind) |
There was a problem hiding this comment.
change of concern.
Rest of the change is reformatting by golines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were getting resource not found errors when fetching resources with the dynamic client.
The issue was that the "Kind" alone wasn't specific enough to get the correct dynamic client. Example: I had two HelmChart kinds
Changed that to create the dynamic client for <Group, Version, Kind> instead.