GH258: Replaces single quotes with repr in f strings #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
changed the title
MaxDall
requested changes
Jul 8, 2023
…rect a spelling mistake
# Conflicts: # src/fundus/scraping/html.py
|
@MaxDall I merged the latest master, the CI fails because I use a fork. All comments have been resolved. |
MaxDall
requested changes
Aug 29, 2023
src/fundus/parser/base_parser.py
Outdated
| @@ -70,9 +70,9 @@ def __lt__(self, other): | |||
|
|
|||
| def __repr__(self): | |||
| if instance := self.__self__: | |||
| return f"bound {type(self).__name__} of {instance}: {self.__wrapped__} --> '{self.__name__}'" | |||
| return f"bound {type(self).__name__} of {instance}: {self.__wrapped__} --> !r{self.__name__}" | |||
There was a problem hiding this comment.
Unfortunately, it seems that you have misused the !r operator. It's supposed to be placed inside the curly braces like this:
... {self.__name__!r}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update the fstrings present in this repository to use
repr()instead of single quotes. I used a regex to find all of these instances.Closes #258