Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use !r instead of single quotes for strings in f-strings #454

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Use !r instead of single quotes for strings in f-strings #454

merged 2 commits into from
Apr 24, 2024

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Apr 24, 2024

Additionally this re formats some logging messages.

closes #276

@MaxDall MaxDall added the enhancement Improvements upon existing features. label Apr 24, 2024
@MaxDall MaxDall requested a review from addie9800 April 24, 2024 15:06
@MaxDall MaxDall changed the base branch from master to module_logging April 24, 2024 15:06
Base automatically changed from module_logging to master April 24, 2024 15:07
addie9800
addie9800 requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are still some leftover cases, where the string representation has not been changed yet, namely: data.py:55, (not sure if needed but) article.py:86-90, utility.py:199, mdr.py:25, dw.py:26, the_gateway_pundit.py:19, base_object.py:74

src/fundus/publishers/base_objects.py Show resolved Hide resolved
src/fundus/publishers/base_objects.py Show resolved Hide resolved
src/fundus/scraping/scraper.py Outdated Show resolved Hide resolved
@MaxDall
Copy link
Collaborator Author

MaxDall commented Apr 24, 2024

I think there are still some leftover cases, where the string representation has not been changed yet, namely: data.py:55, (not sure if needed but) article.py:86-90, utility.py:199, mdr.py:25, dw.py:26, the_gateway_pundit.py:19, base_object.py:74

Hey, @addie9800. Thanks for the detailed review 👍 I checked every occurrence of '{ in the codebase before I commited and all remaining occurrences are either not a string or on purpose.

addie9800
addie9800 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MaxDall MaxDall merged commit be8addc into master Apr 24, 2024
5 checks passed
@MaxDall MaxDall deleted the use-reprs-for-strings branch April 24, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addie9800 addie9800 addie9800 approved these changes

Assignees
No one assigned
Labels
enhancement Improvements upon existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxDall @addie9800