Skip to content

Commit

Permalink
[Logs Explorer] Fix discover tab time range test (elastic#173198)
Browse files Browse the repository at this point in the history
  • Loading branch information
weltenwort authored Dec 13, 2023
1 parent e9e9041 commit 5f6dfb6
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'svlCommonNavigation',
]);

// Failing: See https://github.com/elastic/kibana/issues/173165
// Failing: See https://github.com/elastic/kibana/issues/173165
describe.skip('Header menu', () => {
describe('Header menu', () => {
before(async () => {
await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');
await esArchiver.load(
Expand Down Expand Up @@ -52,7 +50,18 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

describe('Discover fallback link', () => {
before(async () => {
await PageObjects.observabilityLogExplorer.navigateTo();
await PageObjects.observabilityLogExplorer.navigateTo({
pageState: {
// avoid aligning with the test data, because that's what Discover
// does later in this test and we wouldn't be able to check the time
// range state transfer
time: {
from: '2023-08-03T00:00:00.000Z',
to: '2023-08-03T12:00:00.000Z',
mode: 'absolute',
},
},
});
await PageObjects.header.waitUntilLoadingHasFinished();
});

Expand Down Expand Up @@ -97,7 +106,18 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

describe('Discover tabs', () => {
before(async () => {
await PageObjects.observabilityLogExplorer.navigateTo();
await PageObjects.observabilityLogExplorer.navigateTo({
pageState: {
// avoid aligning with the test data, because that's what Discover
// does later in this test and we wouldn't be able to check the time
// range state transfer
time: {
from: '2023-08-03T00:00:00.000Z',
to: '2023-08-03T12:00:00.000Z',
mode: 'absolute',
},
},
});
await PageObjects.header.waitUntilLoadingHasFinished();
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export default function ({ loadTestFile }: FtrProviderContext) {
loadTestFile(require.resolve('./filter_controls'));
loadTestFile(require.resolve('./flyout'));
loadTestFile(require.resolve('./header_menu'));
loadTestFile(require.resolve('./header_menu'));
loadTestFile(require.resolve('./flyout_highlights.ts'));
});
}

0 comments on commit 5f6dfb6

Please sign in to comment.