Fix incorrectly passed doc_id param (elastic#173180)

fkanout · Dec 13, 2023 · e9e9041 · e9e9041
1 parent 86bdae2
commit e9e9041
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/...ins/ai_assistant_management/observability/public/hooks/use_create_knowledge_base_entry.ts b/...ins/ai_assistant_management/observability/public/hooks/use_create_knowledge_base_entry.ts
@@ -29,7 +29,7 @@ export function useCreateKnowledgeBaseEntry() {
     {
       entry: Omit<
         KnowledgeBaseEntry,
-        '@timestamp' | 'confidence' | 'is_correction' | 'public' | 'labels' | 'role'
+        '@timestamp' | 'confidence' | 'is_correction' | 'public' | 'labels' | 'role' | 'doc_id'
       >;
     }
   >(

diff --git a/...gement/observability/public/routes/components/knowledge_base_edit_manual_entry_flyout.tsx b/...gement/observability/public/routes/components/knowledge_base_edit_manual_entry_flyout.tsx
@@ -50,7 +50,6 @@ export function KnowledgeBaseEditManualEntryFlyout({
     createEntry({
       entry: {
         id: newEntryId,
-        doc_id: newEntryId,
         text: newEntryText,
       },
     }).then(onClose);

diff --git a/...i_assistant_management/observability/public/routes/components/knowledge_base_tab.test.tsx b/...i_assistant_management/observability/public/routes/components/knowledge_base_tab.test.tsx
@@ -80,7 +80,7 @@ describe('KnowledgeBaseTab', () => {
 
       getByTestId('knowledgeBaseEditManualEntryFlyoutSaveButton').click();
 
-      expect(createMock).toHaveBeenCalledWith({ entry: { id: 'foo', doc_id: 'foo', text: '' } });
+      expect(createMock).toHaveBeenCalledWith({ entry: { id: 'foo', text: '' } });
     });
   });
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,7 +80,7 @@ describe('KnowledgeBaseTab', () => { @@
           getByTestId('knowledgeBaseEditManualEntryFlyoutSaveButton').click();
-          expect(createMock).toHaveBeenCalledWith({ entry: { id: 'foo', doc_id: 'foo', text: '' } });
+          expect(createMock).toHaveBeenCalledWith({ entry: { id: 'foo', text: '' } });
         });
       });
@@ Expand Down @@