-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOAS package and better TH support for complex types #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #27.
Here SOAS package serves merely as an example of a more complex grammar/types to generate Free Foil for. Later, it should also have proper library definitions.
This PR is a reimplementation of TH generation for Free Foil, providing simultaneous definition for many types:
What is NOT supported (and is not planned in this PR):
separate scope namespaces (e.g. if you put a type annotation in a term (or term pattern), it will be "dependent" in the sense that its scope will be shared/related to the term's scope); supporting separate namespaces would require more substantial change to the
AST
type, e.g. something likehypertypes
CoSinkable
instances are not generated here, instead I plan to implement a generic version based onkind-generics
, similarly toZipMatchK
Note that this PR contains 1k+ LoC of Template Haskell, which means there are probably some bugs 🐞