Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing name from kmv to mlt #36

Closed
wants to merge 1 commit into from
Closed

Conversation

Olender
Copy link

@Olender Olender commented May 25, 2023

This PR was made just to rename the KMV elements. KMV is a bit of a misnomer, since the last name of the first author of the cited paper is actually Chin-Joe-Kong (https://link.springer.com/article/10.1023/A:1004420829610).

Also, since this type of higher order triangular mass lumped triangular elements for the wave equation has been the subject of many papers getting the name of every researcher involved would be quite a list, therefore, I propose we just follow the nomenclature from the articles the used quadrature points come from and call them MLT.

Articles:

Higher-order triangular and tetrahedral finite elements with mass
lumping for solving the wave equation
M. J. S. CHIN-JOE-KONG, W. A. MULDER and M. VAN VELDHUIZEN

Higher-order Mass-lumped Finite Elements for the Wave Equation
W.A. MULDER

New Higher-order Mass-lumped Tetrahedral Elements
S. GEEVERS, W.A. MULDER, AND J.J.W. VAN DER VEGT

The related PRs for TSFC, FIAT, Firedrake, and FInAT are forthcoming.
Kind regards,

Associated Pull Requests:

@dham
Copy link
Member

dham commented Jun 2, 2023

Hi @Olender, please open UFL PRs against the upstream FEniCS UFL rather than against the Firedrake one.

@dham dham closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants