Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olender/kmv to mlt rename #2945

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Olender/kmv to mlt rename #2945

wants to merge 3 commits into from

Conversation

Olender
Copy link

@Olender Olender commented May 25, 2023


name: Name change of an element
description: 'This PR was made just to rename the KMV elements.


Description

This PR was made just to rename the KMV elements. KMV is a bit of a misnomer, since the last name of the first author of the cited paper is actually Chin-Joe-Kong (https://link.springer.com/article/10.1023/A:1004420829610).

Also, since this type of higher order triangular mass lumped triangular elements for the wave equation has been the subject of many papers getting the name of every researcher involved would be quite a list, therefore, I propose we just follow the nomenclature from the articles the used quadrature points come from and call them MLT.

Articles:

Higher-order triangular and tetrahedral finite elements with mass
lumping for solving the wave equation
M. J. S. CHIN-JOE-KONG, W. A. MULDER and M. VAN VELDHUIZEN

Higher-order Mass-lumped Finite Elements for the Wave Equation
W.A. MULDER

New Higher-order Mass-lumped Tetrahedral Elements
S. GEEVERS, W.A. MULDER, AND J.J.W. VAN DER VEGT

This PR is also associated with PRs in UFL, TSFC, FIAT and FInAT.

Associated Pull Requests:

Fixes Issues:

Checklist for author:

  • I have linted the codebase (make lint in the firedrake source directory).
  • My changes generate no new warnings.
    - [ ] All of my functions and classes have appropriate docstrings.
    - [ ] I have commented my code where its purpose may be unclear.
  • I have included and updated any relevant documentation.
  • Documentation builds locally (make linkcheck; make html; make latexpdf in firedrake/docs directory)
    - [ ] I have added tests specific to the issues fixed in this PR.
    - [ ] I have added tests that exercise the new functionality I have introduced
  • Tests pass locally (pytest tests in the firedrake source directory) (useful, but not essential if you don't have suitable hardware).
  • I have performed a self-review of my own code using the below guidelines.

Checklist for reviewer:

- [ ] Docstrings present
- [ ] New tests present

  • Code correctly commented
  • No bad "code smells"
  • No issues in parallel
  • No CI issues (excessive parallelism/memory usage/time/warnings generated)
  • Upstream/dependent branches and PRs are ready

Feel free to add reviewers if you know there is someone who is already aware of this work.

Please open this PR initially as a draft and mark as ready for review once CI tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant