Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Name change of an element
description: 'This PR was made just to rename the KMV elements.
Description
This PR was made just to rename the KMV elements. KMV is a bit of a misnomer, since the last name of the first author of the cited paper is actually Chin-Joe-Kong (https://link.springer.com/article/10.1023/A:1004420829610).
Also, since this type of higher order triangular mass lumped triangular elements for the wave equation has been the subject of many papers getting the name of every researcher involved would be quite a list, therefore, I propose we just follow the nomenclature from the articles the used quadrature points come from and call them MLT.
Articles:
This PR is also associated with PRs in UFL, TSFC, FIAT and FInAT.
Associated Pull Requests:
Fixes Issues:
Checklist for author:
make lint
in thefiredrake
source directory).- [ ] All of my functions and classes have appropriate docstrings.- [ ] I have commented my code where its purpose may be unclear.make linkcheck; make html; make latexpdf
infiredrake/docs
directory)- [ ] I have added tests specific to the issues fixed in this PR.- [ ] I have added tests that exercise the new functionality I have introducedpytest tests
in thefiredrake
source directory) (useful, but not essential if you don't have suitable hardware).Checklist for reviewer:
- [ ] Docstrings present- [ ] New tests presentFeel free to add reviewers if you know there is someone who is already aware of this work.
Please open this PR initially as a draft and mark as ready for review once CI tests are passing.