forked from FEniCS/fiat
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup H(div, S) elements #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e correct order wrt h
rckirby
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor complaint about appearing to generalize something that might create a future problem.
pbrubeck
force-pushed
the
pbrubeck/hu-zhang
branch
from
October 29, 2024 23:10
5f278bd
to
a46bd36
Compare
* TracelessTensorPolynomialSet * Add GLS H(curl div) element
pbrubeck
added a commit
that referenced
this pull request
Nov 19, 2024
* docstring * cleanup test_fiat.py * Regge integral dofs * HHJ integral dofs in 2d/3d * support variant="integral(q)" * BidirectionalMoment dofs * address review comments * Cleanup H(div, S) elements (#98) * implementation of Hu-Zhang element --------- Co-authored-by: Francis Aznaran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleanup of zany Piola-mapped elements.
Adding the Hu-Zhang element, credits to @FAznaran