Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bp v1.5] backport CI changes to make the AB perf pipeline work #4400

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[bp v1.5] backport CI changes to make the AB perf pipeline work #4400

merged 1 commit into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. test: Fix default handling of pipeline_perf --test argument 

    argparse's `action="append"` interacts unexpectedly with default
arguments, in the sense that it will _always_ include the default
arguments in the resulting list, and then appends any actually specified
argument to the default list. This meant that doing something like
`.buildkite/pipeline_perf.py --test memory-overhead` will first cause
steps for _every_ performance test be added, and then another copy of
the memory overhead step.

(cherry picked from commit 959ecdd)

Signed-off-by: Patrick Roy <[email protected]>
    @roypat @pb8o
    roypat authored and pb8o committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4bb4d68 View commit details
    Browse the repository at this point in the history