[bp v1.5] backport CI changes to make the AB perf pipeline work #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argparse's `action="append"` interacts unexpectedly with default arguments, in the sense that it will _always_ include the default arguments in the resulting list, and then appends any actually specified argument to the default list. This meant that doing something like `.buildkite/pipeline_perf.py --test memory-overhead` will first cause steps for _every_ performance test be added, and then another copy of the memory overhead step. (cherry picked from commit 959ecdd) Signed-off-by: Patrick Roy <[email protected]>
pb8o
added
Priority: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.5 #4400 +/- ##
=================================================
Coverage 83.02% 83.02%
=================================================
Files 223 223
Lines 28493 28493
=================================================
Hits 23656 23656
Misses 4837 4837
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wearyzen
approved these changes
Jan 23, 2024
|
Thanks! |
zulinx86
approved these changes
Jan 23, 2024
wearyzen
merged commit 7ae378a
into
firecracker-microvm:firecracker-v1.5
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There was a change to the AB perf pipeline that wasn't matched in the code.
Reason
To continue trigerring the AB perf pipeline after merged in the v1.5 branch
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.