Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and update OR query tests. #11826

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Clean up and update OR query tests. #11826

merged 1 commit into from
Oct 2, 2023

Conversation

ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas self-assigned this Sep 19, 2023
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Sep 29, 2023
milaGGL
milaGGL approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas merged commit 84c8bd0 into master Oct 2, 2023
42 checks passed
@ehsannas ehsannas deleted the ehsann/update-or-query-tests branch October 2, 2023 17:29
@ehsannas ehsannas mentioned this pull request Oct 19, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@milaGGL milaGGL

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @milaGGL