Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OR query Swift tests. #11969

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Update OR query Swift tests. #11969

merged 1 commit into from
Oct 20, 2023

Conversation

ehsannas
Copy link
Contributor

This is the same as #11826 for the Swift tests.

@ehsannas ehsannas self-assigned this Oct 19, 2023
@ehsannas ehsannas mentioned this pull request Oct 19, 2023
Merged
@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ehsannas ehsannas requested a review from milaGGL October 19, 2023 23:02
@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Oct 19, 2023
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.18% (f73ca95) to 88.07% (3775b71) by -0.11%.

    FilenameBase (f73ca95)Merge (3775b71)Diff
    exception.cc84.21%23.68%-60.53%
    filesystem_posix.cc81.82%79.09%-2.73%
    leveldb_key.cc98.53%98.82%+0.29%
    leveldb_mutation_queue.cc93.56%92.42%-1.14%
    leveldb_remote_document_cache.cc96.55%94.83%-1.72%
    task.cc93.91%94.78%+0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KBE9glrEc1.html

milaGGL
milaGGL approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milaGGL milaGGL assigned ehsannas and unassigned milaGGL Oct 20, 2023
@ehsannas ehsannas merged commit 3af0241 into master Oct 20, 2023
43 checks passed
@ehsannas ehsannas deleted the ehsann/update-or-query-tests-swift branch October 20, 2023 16:25
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@ehsannas ehsannas

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @milaGGL