Do not run F3 tests in parallel #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeated runs on CI shows that there is some contention when `f3_test.go` tests are run in parallel. See #700. Avoid F3 test flakiness by running them serially. This fixes the symptom that is test flakiness but not the root cause. The root cause may be within one of the test dependencies. Fixes #623, #659, #684, #699
This was
linked to
issues
Oct 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
==========================================
- Coverage 76.54% 76.36% -0.18%
==========================================
Files 69 69
Lines 5584 5584
==========================================
- Hits 4274 4264 -10
- Misses 901 909 +8
- Partials 409 411 +2 |
Stebalien
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeated runs on CI shows that there is some contention when
f3_test.gotests are run in parallel. See #700. Avoid F3 test flakiness by running them serially.This fixes the symptom that is test flakiness but not the root cause. The root cause may be within one of the test dependencies.
Compared to
mainthe changes here don't make much difference in terms of the length of time it takes for CI to run the tests.Fixes #623, #659, #684, #699