Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestF3FailRecover is flaky #699

Closed
masih opened this issue Oct 7, 2024 · 0 comments · Fixed by #705
Closed

TestF3FailRecover is flaky #699

masih opened this issue Oct 7, 2024 · 0 comments · Fixed by #705
Milestone
Milestone 2: F3 H...

Comments

@masih
Copy link
Member

masih commented Oct 7, 2024

See build on main branch
@github-project-automation github-project-automation bot moved this to Todo in F3 Oct 7, 2024
masih added a commit that referenced this issue Oct 8, 2024
@masih
Do not run F3 tests in parallel
4a928a9 
Repeated runs on CI
shows that there is some contention when `f3_test.go` tests are run in
parallel. See #700. Avoid F3 test flakiness by running them serially.

This fixes the symptom that is test flakiness but not the root cause.
The root cause may be within one of the test dependencies.

Fixes #623, #659, #684, #699
@masih masih mentioned this issue Oct 8, 2024
Merged
@masih masih linked a pull request Oct 8, 2024 that will close this issue
Do not run F3 tests in parallel #705
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 8, 2024
@masih
Do not run F3 tests in parallel (#705)
8f6c558 
Repeated runs on CI
shows that there is some contention when `f3_test.go` tests are run in
parallel. See #700. Avoid F3 test flakiness by running them serially.

This fixes the symptom that is test flakiness but not the root cause.
The root cause may be within one of the test dependencies.

Fixes #623, #659, #684, #699
@github-project-automation github-project-automation bot moved this from Todo to Done in F3 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
F3
Status: Done
Milestone
Milestone 2: F3 Hardening and Mainnet...
Development

Successfully merging a pull request may close this issue.

Do not run F3 tests in parallel filecoin-project/go-f3
1 participant
@masih