Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Win32 #56

Closed
wants to merge 1 commit into from
Closed

Change Win32 #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libavcodec/vvc_thread.c
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be

#ifdef _MSC_VER

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is meant to be a fix for the issues with MinGW cross-compilation mentioned in #55. This allows MinGW to compile (not run without errors though) but breaks compilation on gcc for Linux and introduces a warning with MSVC in the process.

Hi fankplow

I'm an amateur who got annoyed on the doom9 forum with a lot of vvc ads and no specific types of examples of converters made.
So I decided to manually make ffmpeg with vvc, evc, htj2k, jxs, jxl, avs, avs2, avs3 converter and see if it works and how it works.
There were problems because many functions overlap from different codecs and some small bugs that I tried to fix.
It took me 1.5 months.
I converted ultravideo kvazaar addon into vvc uvg266. FFmpeg makes codecs, but only vvc, mts.
The problem is they don't play. Non-standard codec?
As for Elecard's vvc bin advertising files. Only some frames are displayed.
gcc issues and the __atomic function.
From what I can see the GNOME based librsvg addon has dropped gcc compatibility with WIN32. As a non-startable function, only MSVC is usable. So the rsvg decoder was trashed.
https://gitlab.gnome.org/GNOME/glib/-/issues/600

Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ int ff_vvc_task_run(Task *_t, void *local_context, void *user_data)

if (!atomic_load(&ft->ret)) {
if ((ret = run[t->type](s, lc, t)) < 0) {
#ifdef WIN32
#ifndef WIN32
intptr_t zero = 0;
#else
int zero = 0;
Expand Down