-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Win32 #56
Change Win32 #56
Conversation
Jamaika1
commented
Apr 2, 2023
``` In file included from vvcdec.h:27, from vvc_thread.h:26, from vvc_thread.c:23: vvc_thread.c: In function 'ff_vvc_task_run': vvc_thread.c:577:13: error: size mismatch in argument 2 of '__atomic_compare_exchange' 577 | atomic_compare_exchange_strong(&ft->ret, &zero, ret); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ```
Think this is meant to be a fix for the issues with MinGW cross-compilation mentioned in #55. This allows MinGW to compile (not run without errors though) but breaks compilation on gcc for Linux and introduces a warning with MSVC in the process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be
#ifdef _MSC_VER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is meant to be a fix for the issues with MinGW cross-compilation mentioned in #55. This allows MinGW to compile (not run without errors though) but breaks compilation on gcc for Linux and introduces a warning with MSVC in the process.
Hi fankplow
I'm an amateur who got annoyed on the doom9 forum with a lot of vvc ads and no specific types of examples of converters made.
So I decided to manually make ffmpeg with vvc, evc, htj2k, jxs, jxl, avs, avs2, avs3 converter and see if it works and how it works.
There were problems because many functions overlap from different codecs and some small bugs that I tried to fix.
It took me 1.5 months.
I converted ultravideo kvazaar addon into vvc uvg266. FFmpeg makes codecs, but only vvc, mts.
The problem is they don't play. Non-standard codec?
As for Elecard's vvc bin advertising files. Only some frames are displayed.
gcc issues and the __atomic function.
From what I can see the GNOME based librsvg addon has dropped gcc compatibility with WIN32. As a non-startable function, only MSVC is usable. So the rsvg decoder was trashed.
https://gitlab.gnome.org/GNOME/glib/-/issues/600
Hi @Jamaika1
VVC is a recent codec and so it is not supported in many players yet, including ffplay and VLC. It very much is standardised though.
I'm not sure quite what you mean by this, but I don't think that only MSVC is usable and I don't see FFmpeg dropping Linux/gcc support any time soon. |
|
@Jamaika1 , could you help confirm the fix and close this? |