Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate Red Hat subscription on demand #3426

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Activate Red Hat subscription on demand #3426

merged 1 commit into from
Oct 15, 2024

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Sep 26, 2024

Fix #2132

@FrostyX FrostyX force-pushed the subscription-ondemand branch from b1320b1 to a4e9ee7 Compare September 29, 2024 11:48
@FrostyX FrostyX force-pushed the subscription-ondemand branch from a4e9ee7 to 4aad4d6 Compare September 29, 2024 11:53
@FrostyX FrostyX force-pushed the subscription-ondemand branch from 4aad4d6 to f4120f2 Compare September 30, 2024 15:11
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 30, 2024
View reviewed changes
rpmbuild/copr_rpmbuild/rhsm.py Fixed Show fixed Hide fixed
rpmbuild/copr_rpmbuild/rhsm.py Fixed Show fixed Hide fixed
rpmbuild/copr_rpmbuild/rhsm.py Fixed Show fixed Hide fixed
rpmbuild/copr_rpmbuild/rhsm.py Fixed Show fixed Hide fixed
@FrostyX FrostyX force-pushed the subscription-ondemand branch from f4120f2 to 606a150 Compare September 30, 2024 15:22
@FrostyX FrostyX marked this pull request as ready for review September 30, 2024 20:13
@FrostyX
Copy link
Member Author

FrostyX commented Sep 30, 2024

Updated PTAL

praiskup
praiskup reviewed Oct 1, 2024
View reviewed changes
rpmbuild/main.py Outdated Show resolved Hide resolved
@FrostyX FrostyX force-pushed the subscription-ondemand branch from 606a150 to bc68241 Compare October 4, 2024 09:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 4, 2024
View reviewed changes
rpmbuild/main.py Fixed Show fixed Hide fixed
@FrostyX FrostyX force-pushed the subscription-ondemand branch 3 times, most recently from 2aedbb2 to 25a2ce5 Compare October 4, 2024 09:58
@FrostyX FrostyX mentioned this pull request Oct 8, 2024
Merged
@FrostyX FrostyX force-pushed the subscription-ondemand branch from 25a2ce5 to 838f56a Compare October 8, 2024 06:43
praiskup added a commit to praiskup/copr that referenced this pull request Oct 10, 2024
@praiskup
rpmbuild: add tooling for "safer" RH subscription
26e9b7f 
The daemon part partly a C&P from
https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh

Closes: fedora-copr#3434
Relates: fedora-copr#3426
praiskup added a commit to praiskup/copr that referenced this pull request Oct 10, 2024
@praiskup
rpmbuild: add tooling for "safer" RH subscription
fcf658e 
The daemon part partly a C&P from
https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh

Closes: fedora-copr#3434
Relates: fedora-copr#3426
praiskup added a commit to praiskup/copr that referenced this pull request Oct 14, 2024
@praiskup
rpmbuild: add tooling for "safer" RH subscription
940ea93 
The daemon part partly a C&P from
https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh

Closes: fedora-copr#3434
Relates: fedora-copr#3426
praiskup added a commit to praiskup/copr that referenced this pull request Oct 14, 2024
@praiskup
rpmbuild: add tooling for "safer" RH subscription
f32bcd3 
The daemon part partly a C&P from
https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh

Closes: fedora-copr#3434
Relates: fedora-copr#3426
nikromen pushed a commit that referenced this pull request Oct 14, 2024
@praiskup @nikromen
rpmbuild: add tooling for "safer" RH subscription
1685748 
The daemon part partly a C&P from
https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh

Closes: #3434
Relates: #3426
@FrostyX FrostyX force-pushed the subscription-ondemand branch from 838f56a to 614c56b Compare October 15, 2024 12:22
@FrostyX FrostyX force-pushed the subscription-ondemand branch 3 times, most recently from 743fc29 to ee70658 Compare October 15, 2024 12:52
praiskup
praiskup reviewed Oct 15, 2024
View reviewed changes
backend/copr_backend/background_worker_build.py
self.log.info(stdout)
if rc:
self.log.info(stderr)
raise BuildRetry("Builder wasn't ready, trying a new one")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit: separate method would be nice

praiskup
praiskup reviewed Oct 15, 2024
View reviewed changes
backend/tests/test_background_worker_build.py Outdated
return (1, "err stdout", "err stderr")
return (0, "", "")
return (1, b"err stdout", "err stderr")
return (0, b"", "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does stdout come out as a binary output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a leftover from before I used run_expensive, thanks for catching that

@FrostyX FrostyX force-pushed the subscription-ondemand branch from ee70658 to da8c763 Compare October 15, 2024 13:38
praiskup
praiskup approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@FrostyX FrostyX merged commit 271b9fa into fedora-copr:main Oct 15, 2024
8 checks passed
praiskup added a commit to praiskup/copr that referenced this pull request Oct 17, 2024
@praiskup
backend: always log copr-builder-ready std{out,err}
cde25ff 
Complements: fedora-copr#3426
@praiskup praiskup mentioned this pull request Oct 17, 2024
Closed
praiskup added a commit to praiskup/copr that referenced this pull request Oct 17, 2024
@praiskup
backend: always log copr-builder-ready std{out,err}
0fd72d6 
Complements: fedora-copr#3426
ryanlerch pushed a commit to fedora-infra/ansible that referenced this pull request Nov 27, 2024
@FrostyX
copr-be: use copr-builder-rhsm-subscribe-daemon to activate subscription
1f55cc9 
See fedora-copr/copr#3434
See fedora-copr/copr#3426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praiskup praiskup praiskup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subscription manager breaks our spawners
2 participants
@FrostyX @praiskup