rpmbuild: add copr-builder-rhsm-subscribe script #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
commented
Sep 30, 2024
praiskup
force-pushed
the
praiskup-rhsm
branch
3 times, most recently
from
34e7264 to
98cc938
Compare
praiskup
commented
Oct 1, 2024
|
if this will be closed (not merged), we need to do the expect magic in fedora-infra/ansible |
FrostyX
reviewed
Oct 8, 2024
| $fail && exit 1 | ||
|
|
||
| try_indefinitely copr-builder-rhsm-subscribe | ||
| try_indefinitely subscription-manager attach --pool "$opt_pool_id" |
There was a problem hiding this comment.
Can you please touch some /var/run file here? Please see #3426 (comment)
praiskup
added a commit
to praiskup/copr
that referenced
this pull request
Oct 10, 2024
The daemon part partly a C&P from https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh Closes: fedora-copr#3434 Relates: fedora-copr#3426
praiskup
force-pushed
the
praiskup-rhsm
branch
from
98cc938 to
26e9b7f
Compare
|
Some new observations:
|
praiskup
added a commit
to praiskup/copr
that referenced
this pull request
Oct 10, 2024
The daemon part partly a C&P from https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh Closes: fedora-copr#3434 Relates: fedora-copr#3426
praiskup
force-pushed
the
praiskup-rhsm
branch
from
26e9b7f to
fcf658e
Compare
FrostyX
reviewed
Oct 14, 2024
FrostyX
reviewed
Oct 14, 2024
| import getpass | ||
| import sys | ||
|
|
||
| from subscription_manager.scripts.subscription_manager import main as rhsm |
There was a problem hiding this comment.
I am a bit afraid of them changing the location or the internals of the script and I would probably rather call it through subprocess but we can do this.
There was a problem hiding this comment.
This is sub-optimal, but subprocess.call means the key goes to /proc/self/cmdline
There was a problem hiding this comment.
Can you please add a code comment about that so that I don't get the great idea to re-implement it someday? :-)
|
This PR is probably blocked by the switch of our account to SCA, right? |
praiskup
added a commit
to praiskup/copr
that referenced
this pull request
Oct 14, 2024
The daemon part partly a C&P from https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh Closes: fedora-copr#3434 Relates: fedora-copr#3426
praiskup
force-pushed
the
praiskup-rhsm
branch
from
fcf658e to
940ea93
Compare
Not really, this can stay unused till we switch. |
The daemon part partly a C&P from https://pagure.io/fedora-infra/ansible/blob/8ff1e6d9f79ca86e/f/roles/copr/backend/files/provision/copr-rh-subscribe.sh Closes: fedora-copr#3434 Relates: fedora-copr#3426
praiskup
force-pushed
the
praiskup-rhsm
branch
from
940ea93 to
f32bcd3
Compare
FrostyX
approved these changes
Oct 14, 2024
ryanlerch
pushed a commit
to fedora-infra/ansible
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to specify RHSM password so it is not visible on
ps auxoutput