Fix F40 FTBFS for copr-frontend #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I fixed ~50 tests, 3 are still remaining Not sure about the cause. Maybe it is something different than the changes I already made. |
|
Thank you, good progress! |
FrostyX
force-pushed
the
ftbfs-f40-frontend
branch
from
a103b7a to
a9cfd30
Compare
See fedora-copr#3130 AttributeError: 'Engine' object has no attribute 'execute' And also use text for raw SQL commands Use the text() construct, or the Connection.exec_driver_sql() method to invoke a driver-level SQL string. And finially setting `future=True` which is going to be passed to `create_engine` by Flask-SQLAlchemy to ensure compatibility between SQLAlchemy 1.x and 2.0. Otherwise we would get AttributeError: 'Connection' object has no attribute 'commit'
See fedora-copr#3130 sqlalchemy.exc.InvalidRequestError: No 'on clause' argument may be passed when joining to a relationship path as a target
See fedora-copr#3130 This is a straightforward case. We cannot join or select using attribute names represented as strings. sqlalchemy.exc.ArgumentError: Strings are not accepted for attribute names in loader options; please use class-bound attributes directly. This one is a bit harder to understand. sqlalchemy.exc.ArgumentError: expected ORM mapped attribute for loader strategy argument Easier to show on an example. When selecting e.g. `BuildChroot` and wanting to join the build information, we cannot do `join(models.Build)` but instead, we need to `join(models.BuildChroot.build)`.
See fedora-copr#3130 For some reason the order of `[x.name for x in self.c3.copr_chroots]` is different SQLAlchemy 1 and 2. F39: ['fedora-18-x86_64', 'fedora-rawhide-i386'] F40: ['fedora-rawhide-i386', 'fedora-18-x86_64']
FrostyX
force-pushed
the
ftbfs-f40-frontend
branch
from
a9cfd30 to
5a04803
Compare
|
Everything fixed, PTAL. |
praiskup
approved these changes
Mar 7, 2024
|
Very good job, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3130