Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly depend on SQLAlchemy < 2 #3191

Closed
wants to merge 1 commit into from

Conversation

nphilipp
Copy link
Contributor

No description provided.

@FrostyX
Copy link
Member

FrostyX commented Mar 19, 2024

Hello @nphilipp,
thank you for the PR.

I recently worked on compatibility with SQLAlchemy 2, please take a look at #3172. I think we don't have to stay on 1.x anymore?

@nphilipp
Copy link
Contributor Author

Fedora 40 has SQLAlchemy 2.0.x, prior versions have 1.4.x which comes with the new API. Let me take a look at that other PR!

@nphilipp
Copy link
Contributor Author

@FrostyX yeah, with that patch in, restricting to sqlalchemy versions < 2 isn’t necessary.

@nphilipp nphilipp closed this Mar 19, 2024
@FrostyX
Copy link
Member

FrostyX commented Mar 19, 2024

Alright, thank you for taking a look :-)

@nphilipp nphilipp deleted the main--no-sqlalchemy2 branch March 27, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants