Datapack parsing #455
Merged
Datapack parsing #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a generator for vanilla tags; Implemented parsing of tag files.
Introduced helper types for serialization; Implmented the recipe registry that discards "special" recipes.
|
Considering the significance of these changes, I would like @caelunshun to review them. |
|
In my opinion prefer into namespace. |
|
The functions now take |
Defman
requested changes
Sep 6, 2021
feather/datapacks/tags.py
Outdated
| @@ -0,0 +1,42 @@ | |||
| from os import listdir | |||
There was a problem hiding this comment.
Should be moved into the generator directory.
|
Moved the tags generator. I believe the recipe implementation can be finished together with crafting. |
Tracreed
added a commit
to Tracreed/feather
that referenced
this pull request
Sep 24, 2021
This reverts commit 7e46ec7.
6 tasks
Defman
pushed a commit
that referenced
this pull request
Sep 24, 2021
Defman
pushed a commit
that referenced
this pull request
Sep 25, 2021
koskja
added a commit
to koskja/feather
that referenced
this pull request
Dec 29, 2021
This reverts commit 7e46ec7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datapack parsing
Status
Description
The game needs to parse registries for most of its logic to function. This pull request attempts to do that.
Related issues
#429
Checklist
cargo fmt,cargo clippy --all-targets,cargo build --releaseandcargo testand fixed any generated errors!Note: if you locally don't get any errors, but GitHub Actions fails (especially at
clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.