Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Datapack parsing (#455)" #478

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Revert "Datapack parsing (#455)" #478

merged 2 commits into from
Sep 24, 2021

Conversation

Tracreed
Copy link
Contributor

Revert "Datapack parsing (#455)"

Status

  • Ready
  • Development
  • Hold

Description

Reverted #455

Related issues

Leave empty if none

Checklist

  • Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • Removed unnecessary commented out code
  • Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Copy link
Contributor

@ambeeeeee ambeeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality and runtime issues exist in the PR, fixes are in progress but it staying is causing issues

@Defman Defman merged commit cf650cc into feather-rs:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants