Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glb viewer can't show marker sequence only #93

Closed
wants to merge 1 commit into from
Closed

Fix glb viewer can't show marker sequence only #93

wants to merge 1 commit into from

Commits on Oct 3, 2024

  1. Fix glb viewer can't show marker sequence only 

    Summary:
The viewer exit when finding that there's no character motion in the glb, but didn't check if it has marker data. This diff revive visualizing marker sequence data with the glb viewer. 

# Changes: 
- After logging the static mesh, don't return yet. Check if there's MarkerSequence, and if so, log markers.

Reviewed By: jeongseok-meta

Differential Revision: D63802112
    @nickyhe-gemini @facebook-github-bot
    nickyhe-gemini authored and facebook-github-bot committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    0b1c00e View commit details
    Browse the repository at this point in the history