Fix glb viewer can't show marker sequence only #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The viewer exit when finding that there's no character motion in the glb, but didn't check if it has marker data. This diff revive visualizing marker sequence data with the glb viewer. # Changes: - After logging the static mesh, don't return yet. Check if there's MarkerSequence, and if so, log markers. Reviewed By: jeongseok-meta Differential Revision: D63802112
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63802112 |
|
This pull request has been merged in e5b16f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The viewer exit when finding that there's no character motion in the glb, but didn't check if it has marker data. This diff revive visualizing marker sequence data with the glb viewer.
Changes:
Reviewed By: jeongseok-meta
Differential Revision: D63802112