Skip to content
This repository has been archived by the owner on Dec 26, 2019. It is now read-only.

Add support for tvOS #1030

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

Add support for tvOS #1030

wants to merge 65 commits into from

Conversation

shvul
Copy link

@shvul shvul commented Nov 15, 2018

PROBLEM


Add support for tvOS #640

SOLUTION


  • updated XCTest headers
  • update dependencies
  • added new endpoints (for remote control, elements focusing)
  • added new targets for tvOS
  • implemented new integration app for tvOS
  • implemented separate uittests suite for atv
  • adopted iOS unit tests to tvOS specific and created new ones
  • fixed hit test issues (major logic is taken from Appium)
  • update inspector
  • updated build script and travis configuration

NOTES


As I already mention, I added functionality to perform element explicit focusing. You requested this feature at #195
Tests suite is green

@shvul shvul changed the title Add support for tvOS #640 Add support for tvOS Nov 15, 2018
@mykola-mokhnach
Copy link
Contributor

I would say it makes sense to split the PR into multiple smaller chunks. It is impossible to review such a big amount of source code.

@shvul
Copy link
Author

shvul commented Nov 19, 2018

@mykola-mokhnach I divided tvOS related logic in smaller chunks. Here is the first one: #1032

@mykola-mokhnach
Copy link
Contributor

Thanks @shvul
I think there was already a similar PR, but the owner did not have time to split it. Also, be ready to wait for a while until you get a reply from the repo owner(s)

@g-tiwari
Copy link

g-tiwari commented Feb 7, 2019

Do we have any update on this integration ?
@shvul I would love to help if anything is needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants