Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS]1st: headers #148

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Mar 19, 2019

I start working to port facebookarchive#1030

Full diff is https://github.com/appium/WebDriverAgent/compare/master...KazuCocoa:km/tvos?expand=1 . I've separated the PR into 4 sections. To make the change small, I haven't added tests yet (Just tested by manual. Only on simulator, but tested with Xcode 10.1 and 10.2). Will add it after the work.

After the 4 sections, WDA can work for tvOS like below. Then, we can add tvOS support into xcuitest-driver.
tvOS


After the 4th PR, https://github.com/appium/WebDriverAgent/compare/master...KazuCocoa:km/tvos?expand=1 will be finished. Then, I would like to add tests/Travis build for tvOS build.

You can work WDA on tvOS like below command easily after the above PRs. Screen cast also works.

$ curl -X GET http://172.254.99.37:8100/session/376FFB23-A10E-46A7-A594-655A4A98E923/window/size
{
  "value" : {
    "width" : 1920,
    "height" : 1080
  },
  "sessionId" : "376FFB23-A10E-46A7-A594-655A4A98E923",
  "status" : 0
}
$ curl -X GET http://172.254.99.37:8100/session/376FFB23-A10E-46A7-A594-655A4A98E923/element/05000000-0000-0000-067A-000000000000/focused
{
  "value" : false,
  "sessionId" : "376FFB23-A10E-46A7-A594-655A4A98E923",
  "status" : 0
}
$curl -X GET http://172.254.99.37:8100/session/376FFB23-A10E-46A7-A594-655A4A98E923/wda/element/focused
{
  "value" : {
    "ELEMENT" : "6A000000-0000-0000-067A-000000000000"
  },
  "sessionId" : "376FFB23-A10E-46A7-A594-655A4A98E923",
  "status" : 0
}
$ curl -X GET http://172.254.99.37:8100/session/376FFB23-A10E-46A7-A594-655A4A98E923/element/6A000000-0000-0000-067A-000000000000/focused
{
  "value" : true,
  "sessionId" : "376FFB23-A10E-46A7-A594-655A4A98E923",
  "status" : 0
}

Each PR does not break WDARunner scheme.

@KazuCocoa
Copy link
Member Author

@mykola-mokhnach
Copy link

mykola-mokhnach commented Mar 19, 2019

It also makes sense to add a TvOS-based test to Travis, to just make sure it is compilable

@mykola-mokhnach
Copy link

We need to fork https://github.com/KazuCocoa/YYCache to be able to build the lib for tvOS then

Do you mind to commit directly into appium/YYCache?

@KazuCocoa
Copy link
Member Author

ah, yeah, of course. Will create a commit

Do you mind to commit directly into appium/YYCache?

Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work @KazuCocoa!

@KazuCocoa KazuCocoa merged commit 038d2d9 into appium:master Mar 21, 2019
This was referenced Mar 21, 2019
@g-tiwari
Copy link

When can we expect this change to be release in Appium?

@KazuCocoa KazuCocoa mentioned this pull request Mar 30, 2019
@KazuCocoa
Copy link
Member Author

Maybe, in 1.13.0

@KazuCocoa KazuCocoa deleted the km/tvos-dependencies-and-headers branch March 30, 2019 06:44
@g-tiwari
Copy link

g-tiwari commented Apr 1, 2019

That is a great news, waiting for automating tvOS apps via Appium.

@KazuCocoa
Copy link
Member Author

https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/ios/ios-tvos.md
@g-tiwari it is available on current appium@beta.
Do you have a physical Apple TV which is not 4k?
If so, could you help us to test it on them?

@g-tiwari
Copy link

Sure @KazuCocoa , I have the device
I will spend some time testing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants