-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tvOS]1st: headers #148
[tvOS]1st: headers #148
Conversation
It also makes sense to add a TvOS-based test to Travis, to just make sure it is compilable |
Do you mind to commit directly into appium/YYCache? |
ah, yeah, of course. Will create a commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work @KazuCocoa!
When can we expect this change to be release in Appium? |
Maybe, in 1.13.0 |
That is a great news, waiting for automating tvOS apps via Appium. |
https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/ios/ios-tvos.md |
Sure @KazuCocoa , I have the device |
I start working to port facebookarchive#1030
Full diff is https://github.com/appium/WebDriverAgent/compare/master...KazuCocoa:km/tvos?expand=1 . I've separated the PR into 4 sections. To make the change small, I haven't added tests yet (Just tested by manual. Only on simulator, but tested with Xcode 10.1 and 10.2). Will add it after the work.
After the 4 sections, WDA can work for tvOS like below. Then, we can add tvOS support into xcuitest-driver.
After the 4th PR, https://github.com/appium/WebDriverAgent/compare/master...KazuCocoa:km/tvos?expand=1 will be finished. Then, I would like to add tests/Travis build for tvOS build.
You can work WDA on tvOS like below command easily after the above PRs. Screen cast also works.
Each PR does not break WDARunner scheme.