Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gentest and initial tests for intrinsic sizing #1723

Closed
wants to merge 3 commits into from
Closed

Gentest and initial tests for intrinsic sizing #1723

wants to merge 3 commits into from

Commits on Nov 4, 2024

  1. Modify private apis to set, store, and get intrinsic sizing keywords 

    Differential Revision: D63927512
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    37e5f84 View commit details
    Browse the repository at this point in the history

  2. Update public API for intrinsic sizing setters 

    Differential Revision: D64002837
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    9a446fc View commit details
    Browse the repository at this point in the history

  3. Gentest and initial tests for intrinsic sizing (facebook#1723) 

    Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    40fd82d View commit details
    Browse the repository at this point in the history