Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gentest and initial tests for intrinsic sizing #1723

Closed
wants to merge 3 commits into from

Conversation

joevilches
Copy link
Contributor

Summary: Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on width, height, min-width, min-height, max-width, max-height, and flex-basis

Differential Revision: D64145117

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yoga-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 7:40pm

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

joevilches added a commit to joevilches/yoga that referenced this pull request Oct 10, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Differential Revision: D64145117
joevilches added a commit to joevilches/yoga that referenced this pull request Oct 29, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

joevilches added a commit to joevilches/yoga that referenced this pull request Oct 29, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
joevilches added a commit to joevilches/yoga that referenced this pull request Oct 31, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

joevilches added a commit to joevilches/yoga that referenced this pull request Oct 31, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
joevilches added a commit to joevilches/yoga that referenced this pull request Oct 31, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

joevilches added a commit to joevilches/yoga that referenced this pull request Nov 1, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
joevilches added a commit to joevilches/yoga that referenced this pull request Nov 1, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

joevilches added a commit to joevilches/yoga that referenced this pull request Nov 4, 2024
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

Differential Revision: D64002837
Summary:
Pull Request resolved: facebook#1723

Adds gentest support for intrinsic sizing keywords and creates an initial batch of somewhat interesting tests for these keywords on `width`, `height`, `min-width`, `min-height`, `max-width`, `max-height`, and `flex-basis`

Reviewed By: NickGerleman

Differential Revision: D64145117
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64145117

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 867bfae.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by c12e732.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants