[lexical-table] Fix table cell format for selection within cell

[ivailop7]

Currently, the TableCellNode tracks the format of the paragraph inside. This is applied correctly when selection is via table selection (range selection including a table, whole table selection, cells selection).

There is a collection of cases if it's selection within the table cell, since the table cell is not selected the format doesn't propagate to the parent TableCellNode correctly and things get out of sync. This fixes those cases.

Before:

before.mov

After:

Things are in sync

after.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 7, 2024 6:40pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 7, 2024 6:40pm

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	29.66 KB (0%)
lexical - esm	29.48 KB (0%)
@lexical/rich-text - cjs	38.07 KB (0%)
@lexical/rich-text - esm	31.32 KB (0%)
@lexical/plain-text - cjs	36.65 KB (0%)
@lexical/plain-text - esm	28.66 KB (0%)
@lexical/react - cjs	39.83 KB (0%)
@lexical/react - esm	32.75 KB (0%)

[moughxyz]

Hi @ivailop7, I know it's not my place to say. But given you are able to reproduce and demonstrate this issue in the playground, it should also be possible to write an e2e test for this. Given there are many organizations that rely on this codebase, would you be willing to write one, or otherwise specify in your PR description why tests were not included for this change?

[etrepum]

This kinda seems like something that should be handled by the selection class rather than a command? Since we do have a paragraph in every cell maybe it makes sense not to store this format there at all since it can and should already be stored on the paragraph (per #6583)

[ivailop7]

This kinda seems like something that should be handled by the selection class rather than a command? Since we do have a paragraph in every cell maybe it makes sense not to store this format there at all since it can and should already be stored on the paragraph (per #6583)

Yeah, that's probably a better approach and would make preserving the styling on empty cells more consistent. Need to redo it, but my holidays ended, so don't have as much time to do PRs. Will revisit in the coming weeks.