Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-table] Support for vertical cell writing #6545

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ivailop7
Copy link
Collaborator

@ivailop7 ivailop7 commented Aug 23, 2024

Resolves: #4437

vertical_writing.mov

Mechanics:
Chaging the CSS attribute writing-mode to 'vertical-rl' or 'vertical-lr' makes the text direction vertical. Once the text is vertical, most people would center it, to make this work seamlessly, we need to convert the text alignment 'left' to 'bottom', 'center' to 'middle', right to 'top', etc. and apply on TableCell-level. I've updated the FORMAT_ELEMENT_COMMAND in a separate PR (#6582) so we don't have the TableCell coupled to the paragraph within.

if no writing-mode is defined - assume the default horizontal, if writing-mode is present validate only 'vertical-rl' and 'vertical-lr' and ignore all the other deprecated properties as per https://developer.mozilla.org/en-US/docs/Web/CSS/writing-mode#values

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 7:10am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 7:10am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 23, 2024
Copy link

github-actions bot commented Aug 23, 2024

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.22 KB (0%)
@lexical/rich-text - cjs 37.87 KB (0%)
@lexical/rich-text - esm 31.08 KB (0%)
@lexical/plain-text - cjs 36.45 KB (0%)
@lexical/plain-text - esm 28.44 KB (0%)
@lexical/react - cjs 39.64 KB (0%)
@lexical/react - esm 32.52 KB (0%)

@ivailop7 ivailop7 marked this pull request as ready for review August 23, 2024 21:46
@ivailop7 ivailop7 marked this pull request as draft August 23, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Table Cell writing mode
3 participants