Nbuono/implement symphony dataset parser #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewfuentes
commented
Nov 20, 2024
Comment on lines
8
to
13
| if (std::filesystem::exists(image_root_dir)) { | ||
| surveys_.load(image_root_dir.string(), survey_list); | ||
| } else { | ||
| throw std::runtime_error("Error: The path '" + image_root_dir.string() + | ||
| "' does not exist."); | ||
| } |
There was a problem hiding this comment.
If you add //common:check as a dependency, and #include "common/check.hh" you can replace this with:
Suggested change
| if (std::filesystem::exists(image_root_dir)) { | |
| surveys_.load(image_root_dir.string(), survey_list); | |
| } else { | |
| throw std::runtime_error("Error: The path '" + image_root_dir.string() + | |
| "' does not exist."); | |
| } | |
| CHECK(std::filesystem::exists(image_root_dir), "Image root does not exist!", image_root_dir); | |
| surveys_.load(image_root_dir.string(), survey_list); |
This is will spit out a nice backtrace and you can add as many context variables as your want onto the end.
| image = survey.loadImageByImageIndex(j); | ||
| cv::imshow("Symphony Dataset Image", image); | ||
| cv::waitKey(2); | ||
| } | ||
| } |
There was a problem hiding this comment.
Are there any sanity checks you could add?
There was a problem hiding this comment.
I can make sure the image is the right shape and isn't all black pixels. I suppose I could also hard code getting the images myself through the directory and make sure the files are the same too
Co-authored-by: Erick Fuentes <[email protected]>
ewfuentes
commented
Nov 20, 2024
| public: | ||
| DataParser(const std::filesystem::path &image_root_dir, | ||
| const std::vector<std::string> &survey_list); | ||
| ~DataParser(); |
There was a problem hiding this comment.
Is the automatically generated destructor sufficient? Could probably omit declaration/definition if it is.
…root_dir. NOTE: for some reason //experimental/learn_descriptors:symphony_lake_parser failed to build without specifying cxx17. I have no idea why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.