Skip to content

Commit

Permalink
Added symphony-lake-dataset helper repo to workspace.
Browse files Browse the repository at this point in the history
  • Loading branch information
PizzaRoll04 committed Oct 30, 2024
1 parent 47d4123 commit 56ea351
Show file tree
Hide file tree
Showing 11 changed files with 83 additions and 32 deletions.
18 changes: 13 additions & 5 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,12 @@ http_archive(
strip_prefix="protobuf-25.3",
sha256 = "3ae7a8f2181be28e5d694617c2b85c6561ba6a16bfcdc9db8e3a95077cab8815",
patches = [
"@//third_party:protobuf-0002-
)buf_deps.bzl", "protobuf_deps")
"@//third_party:protobuf-0002-use-rules-python-headers.patch",
],
patch_args=["-p1"],
)

load("@com_google_protobuf//:protobuf_deps.bzl", "protobuf_deps")
protobuf_deps()

http_archive(
Expand Down Expand Up @@ -424,9 +428,13 @@ http_archive(
integrity = "sha256-cSp9CdKiJlL7BqSa9RbgUZeaOYStsGfahnYOYO1Rp/U="
)

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
name="fast-cpp-csv-parser",
urls = ["https://github.com/ben-strasser/fast-cpp-csv-parser/archive/refs/heads/master.zip"],
strip_prefix = "fast-cpp-csv-parser-master",
name = "symphony_lake_parser",
urls = ["https://github.com/cedricpradalier/SymphonyLakeDataset/archive/5366560263b660b0151844a297effa517480991a.zip"],
strip_prefix = "SymphonyLakeDataset-5366560263b660b0151844a297effa517480991a",
build_file = "//third_party:BUILD.symphony_lake_parser",
sha256 = "ab80544a4a7d8554e92c49e9b43e5bdbce0d84654798262c36134cd1224070be",
)

20 changes: 0 additions & 20 deletions common/csv_reader/BUILD

This file was deleted.

Empty file removed common/csv_reader/csv_reader.cc
Empty file.
1 change: 0 additions & 1 deletion common/csv_reader/csv_reader.hh

This file was deleted.

Empty file.
21 changes: 21 additions & 0 deletions experimental/learn_descriptors/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,24 @@ cc_test(
":learn_descriptors",
]
)

cc_library(
name = "symphony_lake_parser",
hdrs = ["symphony_lake_parser.hh"],
copts = ["-Wno-unused-parameter"],
visibility = ["//visibility:public"],
srcs = ["symphony_lake_parser.cc"],
deps = [
"@symphony_lake_parser",
]
)

cc_test(
name = "symphony_lake_parser_test",
srcs = ["symphony_lake_parser_test.cc"],
copts = ["-Wno-unused-parameter"],
deps = [
"@com_google_googletest//:gtest_main",
":symphony_lake_parser"
]
)
7 changes: 7 additions & 0 deletions experimental/learn_descriptors/symphony_lake_parser.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#include "experimental/learn_descriptors/symphony_lake_parser.hh"

#include <iostream>

namespace robot::experimental::learn_descriptors::symphony_lake_dataset {
void hello_world(const std::string &msg) { std::cout << msg << std::endl; }
} // namespace robot::experimental::learn_descriptors::symphony_lake_dataset
9 changes: 9 additions & 0 deletions experimental/learn_descriptors/symphony_lake_parser.hh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#pragma once

#include <string.h>

#include "symphony_lake_dataset/SurveyVector.h"

namespace robot::experimental::learn_descriptors::symphony_lake_dataset {
void hello_world(const std::string &msg);
}
7 changes: 7 additions & 0 deletions experimental/learn_descriptors/symphony_lake_parser_test.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
#include "experimental/learn_descriptors/symphony_lake_parser.hh"

#include "gtest/gtest.h"

namespace robot::experimental::learn_descriptors::symphony_lake_dataset {
TEST(SymphonyLakeParserTest, hello_world) { hello_world("womp womp"); }
} // namespace robot::experimental::learn_descriptors::symphony_lake_dataset
6 changes: 0 additions & 6 deletions third_party/BUILD.cpp_fast_csv_parser

This file was deleted.

26 changes: 26 additions & 0 deletions third_party/BUILD.symphony_lake_parser
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package(features=["-warning_compile_flags"])

cc_library(
name = "symphony_lake_parser",
hdrs = [
"include/symphony_lake_dataset/SurveyVector.h",
"include/symphony_lake_dataset/csv_functions.h",
"include/symphony_lake_dataset/Function.h",
"include/symphony_lake_dataset/ImagePoint.h",
"include/symphony_lake_dataset/ParseSurvey.h",
"include/symphony_lake_dataset/Pose.h",
"include/symphony_lake_dataset/Survey.h",
],
copts = ["-Wno-unused-parameter"],
visibility = ["//visibility:public"],
srcs = [
"src/Function.cpp",
"src/ParseSurvey.cpp",
"src/Survey.cpp",
"src/SurveyVector.cpp"
],
strip_include_prefix="include/",
deps = [
"@opencv//:opencv",
],
)

1 comment on commit 56ea351

@PizzaRoll04
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, the external repo creates some unused-parameter warnings (due to Function.h) which I suppress by adding copts = ["-Wno-unused-parameter"] to all BUILD files that depend on symphony_lake_parser target, so I've forked the repo and may use that instead with some changes

Please sign in to comment.