Nbuono/vo #332
Merged
Nbuono/vo #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewfuentes
commented
Nov 12, 2024
| DataParser(const std::string &image_root_dir, const std::vector<std::string> &survey_list); | ||
| ~DataParser(); | ||
|
|
||
| const symphony_lake_dataset::SurveyVector &getSurveys() const { return _surveys; }; |
There was a problem hiding this comment.
The rest of the codebase uses snake case for function names.
|
|
||
| #include "symphony_lake_dataset/SurveyVector.h" | ||
|
|
||
| namespace robot::experimental::learn_descriptors::symphony_lake_parser { |
There was a problem hiding this comment.
In general, the namespace should match the file path to make things easier to find. Remove symphony_lake_parser from the namespace.
| const symphony_lake_dataset::SurveyVector &getSurveys() const { return _surveys; }; | ||
|
|
||
| private: | ||
| symphony_lake_dataset::SurveyVector _surveys; |
There was a problem hiding this comment.
member variables should be suffixed with an underscore instead of prefixed.
Comment on lines
17
to
18
| std::string image_root_dir = "/home/pizzaroll04/Documents/datasets/symphony_lake_full"; | ||
| std::string surveys = "140106"; |
| void hello_world(const std::string &msg); | ||
| class DataParser { | ||
| public: | ||
| DataParser(const std::string &image_root_dir, const std::vector<std::string> &survey_list); |
There was a problem hiding this comment.
image_root_dir can be a std::filesystem::path
experimental/learn_descriptors/vo.hh
Outdated
| cv::Ptr<cv::Feature2D> _feature_extractor; | ||
| cv::Ptr<cv::DescriptorMatcher> _descriptor_matcher; | ||
| }; | ||
| class VO { |
There was a problem hiding this comment.
Consider calling this VisualOdometry instead.
PizzaRoll04
force-pushed
the
nbuono/VO
branch
from
17d1515 to
1e7ec73
Compare
…mage. SIFT seem to work (matches look good) but ORB doesn't work as well at the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.