Adapt scraper for site layout change #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondenman
force-pushed
the
new-site-layout-changes
branch
4 times, most recently
from
45d8baa to
bfd2014
Compare
ondenman
force-pushed
the
new-site-layout-changes
branch
2 times, most recently
from
d05e708 to
399a148
Compare
ondenman
changed the title
ondenman
force-pushed
the
new-site-layout-changes
branch
2 times, most recently
from
8329aad to
a3d24b5
Compare
ondenman
changed the title
ondenman
force-pushed
the
new-site-layout-changes
branch
4 times, most recently
from
ec98989 to
1eb4137
Compare
ondenman
force-pushed
the
new-site-layout-changes
branch
7 times, most recently
from
7173a3c to
c335ede
Compare
added 5 commits
July 7, 2017 15:37
The previous URL now redirects to http://www.tucamarapr.org/dnncamara/web/Inicio.aspx
Phone, fax, party and contact information are no longer listed in individual member rows. Contact form urls are no longer listed in either member rows or on member pages. Phone, fax and party info will be captured in MemberPage which will be added in a forthcoming commit.
ondenman
force-pushed
the
new-site-layout-changes
branch
2 times, most recently
from
e4e1462 to
1274945
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site layout has changed and the scraper no longer pulls in data. This PR updates CSS selectors in
MembersPageandMemberDivand also addsMemberPage.Note:
The scraper was capturing contact form urls for members (e.g. http://www.tucamarapr.org/dnncamara/web/contacto.aspx?rep=35). The forms are still live but I cannot find a link to them in either the member rows or member pages. As such, I have dropped this field.
In addition to voice phone and fax, member pages also list a TTY number. (I've opened a PR in csv_to_popolo to handle TTY numbers: tmtmtmtm/csv_to_popolo#115)