WIP: Site layout changes #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 7, 2017 15:21
The previous URL now redirects to http://www.tucamarapr.org/dnncamara/web/Inicio.aspx
Phone, fax, party and contact information are no longer listed in individual member rows. Contact form urls are no longer listed in either member rows or on member pages. Phone, fax and party info will be captured in MemberPage which will be added in a forthcoming commit.
ondenman
force-pushed
the
site-layout-changes
branch
from
a3ca91b to
60de314
Compare
|
Closing in favour of #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site layout has changed and the scraper no longer pulls in data. This PR updates CSS selectors in MembersPage and MemberDiv and also adds MemberPage.
Note:
The scraper was capturing contact form urls for members (e.g. http://www.tucamarapr.org/dnncamara/web/contacto.aspx?rep=35). The forms are still live but I cannot find a link to them in either the member rows or member pages. As such, I have dropped this field.
In addition to voice phone and fax, member pages also list a TTY number. (I've opened a PR in csv_to_popolo to handle TTY numbers: tmtmtmtm/csv_to_popolo#115)