This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-1968 Convert AnnotationTicketsTable into a list #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #14607 ↗︎
Details:
Review all test suite changes for PR #2180 ↗︎ |
|||||||||||||||
SupaJoon
suggested changes
Dec 12, 2023
Comment on lines
8
to
12
| const validateAnnotationRowCount = (listName: string, count: number) => { | ||
| cy.dataCy(listName).within(() => | ||
| cy.dataCy("annotation-ticket-row").should("have.length", count) | ||
| ); | ||
| }; |
There was a problem hiding this comment.
The readability and debugging overhead of this function can be reduced by aliasing in beforeEach. Check it out:
Suggested change
| const validateAnnotationRowCount = (listName: string, count: number) => { | |
| cy.dataCy(listName).within(() => | |
| cy.dataCy("annotation-ticket-row").should("have.length", count) | |
| ); | |
| }; |
There was a problem hiding this comment.
Woah cool suggestion!
| cy.dataCy(listName).within(() => | ||
| cy.dataCy("annotation-ticket-row").should("have.length", count) | ||
| ); | ||
| }; | ||
| describe("Task Annotation Tab", () => { | ||
| beforeEach(() => { | ||
| cy.visit(taskRoute); |
There was a problem hiding this comment.
Suggested change
| cy.visit(taskRoute); | |
| cy.visit(taskRoute); | |
| cy.dataCy("loading-annotation-ticket").should("not.exist"); | |
| const rowSelector = "[data-cy='annotation-ticket-row']" | |
| cy.dataCy("issues-list").find(rowSelector).as("issueRows") | |
| cy.dataCy("suspected-issues-list").find(rowSelector).as("susIssueRows") | |
| ); |
There was a problem hiding this comment.
Super neat use of aliases Thanks!
Comment on lines
21
to
22
| validateAnnotationRowCount(issuesList, 1); | ||
| validateAnnotationRowCount(suspectedIssuesList, 3); |
There was a problem hiding this comment.
Suggested change
| validateAnnotationRowCount(issuesList, 1); | |
| validateAnnotationRowCount(suspectedIssuesList, 3); | |
| cy.get("@issueRows").should("have.length", 1); | |
| cy.get("@susIssueRows").should("have.length", 3); |
| @@ -118,3 +129,6 @@ const BottomMetaDataWrapper = styled.div` | |||
| margin-top: ${size.xs}; | |||
| width: 80%; | |||
| `; | |||
|
|
|||
| export default AnnotationTicketRow; | |||
There was a problem hiding this comment.
Why not leave this as a named export since named exports for React components is already an established pattern?
Comment on lines
44
to
56
| <JiraSummaryLink | ||
| href={url} | ||
| target="_blank" | ||
| data-cy={issueKey} | ||
| onClick={() => | ||
| annotationAnalytics.sendEvent({ | ||
| name: "Click Annotation Ticket Link", | ||
| }) | ||
| } | ||
| > | ||
| {issueKey} | ||
| {summary && `: ${summary}`} | ||
| </JiraSummaryLink> |
There was a problem hiding this comment.
Save this as a variable in the function body so there isn't repeated JSX
| dispatchToast.success( | ||
| `Successfully moved ${issueString} to ${ | ||
| isIssue ? "suspected issues" : "issues" | ||
| }` |
SupaJoon
approved these changes
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-1968
Description
This "Table" is also not technically a table and is more of a list of elements. This refactors it to reflect that and also removes some of the ANTD dependencies
Screenshots
Testing
Evergreen PR