Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-1971: Remove table for custom tickets #2171

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

sophstad
Copy link
Contributor

DEVPROD-1971

Description

Screenshots

image

Testing

  • Added story

Copy link

cypress bot commented Nov 28, 2023

1 flaky test on run #14579 ↗︎

0 543 10 0 Flakiness 1

Details:

CR comment
Project: Spruce Commit: ddf0d8dfcf
Status: Passed Duration: 24:18 💡
Started: Dec 12, 2023 7:15 PM Ended: Dec 12, 2023 7:39 PM
Flakiness  cypress/integration/breadcrumbs.ts • 1 flaky test

View Output Video

Test Artifacts
Viewing a patch > Viewing a user's own patch > Clicking the 'My Patches' breadcrumb goes to the logged in user's Patches Page when the current patch belongs to the logged in user Screenshots Video

Review all test suite changes for PR #2171 ↗︎

@sophstad sophstad requested a review from a team December 1, 2023 15:36
@sophstad sophstad marked this pull request as ready for review December 1, 2023 15:36
Copy link
Contributor

@SupaJoon SupaJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Move AnnotationTicketRow one directory level up

@@ -17,13 +19,29 @@ const CustomCreatedTickets: React.FC<CustomCreatedTicketProps> = ({
<>
<TicketsTitle>Create a New Ticket</TicketsTitle>
<FileTicketButton taskId={taskId} execution={execution} />
{!!tickets?.length && (
{tickets?.length > 0 && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: avoid mixed type operands (in this case it's undefined and number)

@sophstad
Copy link
Contributor Author

nit: Move AnnotationTicketRow one directory level up

I'll leave this for @khelif96 in #2180 since Annotation Ticket files are touched directly in that PR!

@sophstad sophstad merged commit 9f1f0fb into evergreen-ci:main Dec 12, 2023
5 of 6 checks passed
@sophstad sophstad deleted the DEVPROD-1971 branch December 12, 2023 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants