EVG-21011: Remove BugSnag #2107
Conversation
Passing run #13401 ↗︎
Details:
Review all test suite changes for PR #2107 ↗︎ |
||||||||||||||||||||
scripts/deploy/deploy.sh
Outdated
| ./scripts/deploy/app-version.sh && node ./scripts/deploy/upload-bugsnag-sourcemaps.js | ||
| echo "Source maps uploaded to Bugsnag" | ||
| echo "Exporting REACT_APP_VERSION variable" | ||
| ./scripts/deploy/app-version.sh |
There was a problem hiding this comment.
REACT_APP_VERSION can be removed since it's only used by Bugsnag
There was a problem hiding this comment.
I feel like at some point this was also baked into the index.html but I no longer see the code there.
We should probably add it back.
There was a problem hiding this comment.
I removed the script and added the value to index.html!
There was a problem hiding this comment.
I removed the script and added the value to
index.html!
APP_VERSION will still need to be exported somewhere since it was exported in the script
There was a problem hiding this comment.
It's now passed in directly as an environment variable via the build script in package.json. You can verify that it's present in the <head> right now on https://spruce-staging.corp.mongodb.com!
| metadata: Breadcrumb["data"], | ||
| type: SentryBreadcrumb | ||
| ) => { | ||
| if (!isProductionBuild()) { |
There was a problem hiding this comment.
Why use isProductionBuild (NODE_ENV) instead of isProduction (RELEASE_STAGE)? Sentry replay relies on RELEASE_STAGE
There was a problem hiding this comment.
I assume that this is so we get sentry logging for all environments including the staging and beta environments. isProductionBuild will be true as long as it is a production build.
We are limited on the amount of sentry replay playback so we probably wouldn't want it enabled in every environment, hence why we sample on prod.
EVG-21011
Description
leaveBreadcrumbto use more Sentry-native types.env-cmdrc.jsonand Evergreen variables once changes are deployedTesting