Skip to content

Commit

Permalink
nebulous-gui: new approach to images (#30)
Browse files Browse the repository at this point in the history
env vars are now consumed implicitly using sed
  • Loading branch information
yoctozepto authored Aug 28, 2024
1 parent a60c1cd commit 13a17e5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 34 deletions.
2 changes: 1 addition & 1 deletion charts/nebulous-gui/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.2.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
29 changes: 3 additions & 26 deletions charts/nebulous-gui/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,35 +27,18 @@ spec:
serviceAccountName: {{ include "nebulous-gui.serviceAccountName" . }}
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
initContainers:
- name: {{ .Chart.Name }}-builder
containers:
- name: {{ .Chart.Name }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.builderImage.repository }}:{{ .Values.builderImage.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.builderImage.pullPolicy }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
command:
- npx
- vite
- build
volumeMounts:
- name: static-files
mountPath: /app/dist
env:
{{- toYaml .Values.builderEnv | nindent 12 }}
containers:
- name: {{ .Chart.Name }}-server
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.serverImage.repository }}:{{ .Values.serverImage.tag }}"
imagePullPolicy: {{ .Values.serverImage.pullPolicy }}
ports:
- name: http
containerPort: 80
protocol: TCP
env:
{{- toYaml .Values.env | nindent 12 }}
{{- toYaml .Values.builderEnv | nindent 12 }}
livenessProbe:
httpGet:
path: /
Expand All @@ -66,9 +49,6 @@ spec:
port: http
resources:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
- name: static-files
mountPath: /usr/share/nginx/html
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
Expand All @@ -81,6 +61,3 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
volumes:
- name: static-files
emptyDir: {}
7 changes: 0 additions & 7 deletions charts/nebulous-gui/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@

replicaCount: 1

serverImage:
repository: "docker.io/library/nginx"
pullPolicy: IfNotPresent
tag: "latest"

builderImage:
repository: "quay.io/nebulous/gui-builder"
pullPolicy: IfNotPresent
Expand Down Expand Up @@ -87,5 +82,3 @@ nodeSelector: {}
tolerations: []

affinity: {}

env: []

0 comments on commit 13a17e5

Please sign in to comment.