Skip to content

Commit

Permalink
nebulous-gui-controller: switch the startup image to busybox (#29)
Browse files Browse the repository at this point in the history
Then there is no need to carry `nc` in the actual container image.
  • Loading branch information
yoctozepto authored Aug 28, 2024
1 parent 10358b8 commit a60c1cd
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/nebulous-gui-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.2.0
version: 0.3.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
7 changes: 6 additions & 1 deletion charts/nebulous-gui-controller/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,13 @@ spec:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
initContainers:
- name: wait-for-mongodb
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
image: "{{ .Values.waitForMongodb.image.repository }}:{{ .Values.waitForMongodb.image.tag }}"
imagePullPolicy: {{ .Values.waitForMongodb.image.pullPolicy }}
command: ['sh', '-c', 'until nc -z nebulous-gui-controller-mongodb 27017; do echo waiting for mongodb; sleep 2; done;']
resources:
{{- toYaml .Values.waitForMongodb.resources | nindent 12 }}
securityContext:
{{- toYaml .Values.waitForMongodb.securityContext | nindent 12 }}
containers:
- name: {{ .Chart.Name }}
securityContext:
Expand Down
8 changes: 8 additions & 0 deletions charts/nebulous-gui-controller/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,14 @@ mongodb:
# this enables the built-in mongodb deployment - not recommended for production
enabled: true

waitForMongodb:
image:
repository: "busybox"
pullPolicy: IfNotPresent
tag: "1-musl"
resources: {}
securityContext: {}

env:
- name: ACTIVEMQ_HOST
value: "nebulous-activemq"
Expand Down

0 comments on commit a60c1cd

Please sign in to comment.