-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using blobhash() #68
Using blobhash() #68
Conversation
Gas usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I am a bit surprised about the gas cost. Do you have the contract and tx deploy on testnets? |
Here is a gas profile for |
An optimization is proposed here #70 |
Storage contract is a proxy implementation, so its constructor can't accept any parameters, and that's why we don't use immutable |
An idea is to use ClonesWithImmutableArgs.sol (employed by OP) https://goerli.etherscan.io/address/0x666C3d298B9c360990F901b3Eded4e7a9d7AD446#code#F2#L5 |
Try to fix #62