-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables that are assigned only once are changed to constants #83
Conversation
Generally, a good practice for a PR explanation is to clarify which issue the PR is trying to fix, and what is your solution |
So we may need a brand new testnet to test the PR if we want use the code in the mainnet, right? |
The "sepolia-test" branch was created to archive the currently used contract code. |
fix issues #70 : Because the contract is changed to upgradeable mode, immutables cannot be initialized in the constructor, so they are changed to constant format.
In the test script, a new solidity file is dynamically compiled to generate byteCode to replace the initial byteCode to achieve constant changes.
old constants
gas used
https://dashboard.tenderly.co/lxs/project/tx/sepolia/0xd50f0758967e9826a748f9f76772eeb4be1700ffc37289649fa46eb16c0468b1/gas-usage