Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move init data file functionality out of run script #310

Merged
merged 30 commits into from
Aug 14, 2024
Merged

Move init data file functionality out of run script #310

merged 30 commits into from
Aug 14, 2024

Conversation

syntrust
Copy link
Collaborator

@syntrust syntrust commented Jul 19, 2024

The background is that as more features are supported, the configurations become more and more complex, and maintaining the initialization and startup nodes in one script file becomes increasingly unsustainable.

So we separate the init from run so that the flags can be managed separately.

Also supported --miner.zkey as path to address #266.

Related tutorials change - ethstorage/ethstorage-doc#32.

Tests need to be covered:

  • init.sh: data files created and zkey downloaded, snarkjs installation check in all installation options:
    • pre-built
    • from source
    • use pre-built Docker
    • use local Docker
      • docker-compose
      • run-docker.sh
  • run.sh starts es-node and mining successfully with --miner.zkey as the file path in all the above 3 options.
    • especially in Docker, there is no need to download zkey for a new build as it is mapped to the host disk

@syntrust syntrust marked this pull request as ready for review July 31, 2024 10:56
@syntrust syntrust requested review from ping-ke and qzhodl July 31, 2024 10:56
@syntrust syntrust marked this pull request as draft August 6, 2024 06:15
@syntrust syntrust removed request for qzhodl and ping-ke August 6, 2024 06:16
@syntrust syntrust marked this pull request as ready for review August 7, 2024 03:20
@syntrust syntrust requested review from qzhodl and ping-ke August 7, 2024 03:20
run.sh Outdated Show resolved Hide resolved
run.sh Outdated Show resolved Hide resolved
init.sh Outdated Show resolved Hide resolved
@syntrust syntrust requested a review from qzhodl August 8, 2024 03:13
cmd/es-node/config.go Show resolved Hide resolved
run-l2.sh Show resolved Hide resolved
run-l2.sh Outdated Show resolved Hide resolved
@syntrust syntrust requested review from qzhodl and ping-ke August 13, 2024 06:22
@syntrust syntrust merged commit 87a1fe7 into main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants