-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move init data file functionality out of run script #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Aug 7, 2024
qzhodl
reviewed
Aug 8, 2024
ping-ke
reviewed
Aug 12, 2024
qzhodl
approved these changes
Aug 13, 2024
ping-ke
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background is that as more features are supported, the configurations become more and more complex, and maintaining the initialization and startup nodes in one script file becomes increasingly unsustainable.
So we separate the init from run so that the flags can be managed separately.
Also supported
--miner.zkey
as path to address #266.Related tutorials change - ethstorage/ethstorage-doc#32.
Tests need to be covered:
init.sh
: data files created and zkey downloaded, snarkjs installation check in all installation options:run.sh
starts es-node and mining successfully with--miner.zkey
as the file path in all the above 3 options.