Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support directory in miner.zkey #266

Closed
jhvst opened this issue Apr 4, 2024 · 2 comments
Closed

config: support directory in miner.zkey #266

jhvst opened this issue Apr 4, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jhvst
Copy link

jhvst commented Apr 4, 2024

Rationale

Why should this feature exist?

Currently, es-node mixes build-time artifacts (the snarkjs folder) with runtime artifacts (the zkey files). This causes an awkward situation for deterministic builds which produce a read-only folder derivation, such as with the Nix package manager. Here, the zkey files cannot be placed under the snarkjs folder unless the zkeys are downloaded during the build process. Bundling the zkeys with the package would balloon the derivation size by additional 550MB, which makes it hard to distribute.

What are the use-cases?

By allowing the zkeys to reside in some other folder, one could have e.g. a systemd script which ensures that the files are in the directory, while still using the build-time artifacts for snarkjs.

Implementation

Do you have ideas regarding the implementation of this feature?

Separate the --miner.zkey from utilizing --miner.zk-working-dir, and instead of a single file name, allow an absolute or relative path to be configured for it.

Are you willing to implement this feature?

No, I currently do not have the bandwidth to make the changes.

@jhvst jhvst added the enhancement New feature or request label Apr 4, 2024
@syntrust
Copy link
Collaborator

Hi jhvst, thanks for your suggestion. We will plan this enhancement soon.

@syntrust
Copy link
Collaborator

Close as solved in #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants