Reject invalid DataColumnSidecar for zero blobs
#3953
Merged
+193
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
approved these changes
Oct 2, 2024
ralexstokes
reviewed
Oct 2, 2024
ralexstokes
reviewed
Oct 2, 2024
ralexstokes
reviewed
Oct 2, 2024
ppopth
reviewed
Oct 3, 2024
hwwhww
approved these changes
Oct 3, 2024
tests/core/pyspec/eth2spec/test/eip7594/unittests/test_networking.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hsiao-Wei Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
assert len(sidecar.kzg_commitments) > 0check forDataColumnSidecarobjects. There should never be a situation where aDataColumnSidecaris propagated for a block with zero blobs.In doing so, this PR creates a new
verify_data_column_sidecarfunction and moves the asserts fromverify_data_column_sidecar_kzg_proofsinto it. Plus a bunch of tests.